Mesa (master): freedreno: mark scissor state dirty when enable bit changes

Rob Clark robclark at kemper.freedesktop.org
Wed Oct 22 00:09:13 UTC 2014


Module: Mesa
Branch: master
Commit: 3eb8289aa4cb599e9297ee1a1b5cfbae35ee562a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3eb8289aa4cb599e9297ee1a1b5cfbae35ee562a

Author: Rob Clark <robclark at freedesktop.org>
Date:   Tue Oct 21 11:28:53 2014 -0400

freedreno: mark scissor state dirty when enable bit changes

We don't have a scissor enable bit in hw, so when a raster state change
results in scissor enable bit changing, we need to also mark scissor
state as dirty.

Signed-off-by: Rob Clark <robclark at freedesktop.org>

---

 src/gallium/drivers/freedreno/freedreno_state.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/gallium/drivers/freedreno/freedreno_state.c b/src/gallium/drivers/freedreno/freedreno_state.c
index 2786929..6293f43 100644
--- a/src/gallium/drivers/freedreno/freedreno_state.c
+++ b/src/gallium/drivers/freedreno/freedreno_state.c
@@ -237,8 +237,18 @@ static void
 fd_rasterizer_state_bind(struct pipe_context *pctx, void *hwcso)
 {
 	struct fd_context *ctx = fd_context(pctx);
+	struct pipe_scissor_state *old_scissor = fd_context_get_scissor(ctx);
+
 	ctx->rasterizer = hwcso;
 	ctx->dirty |= FD_DIRTY_RASTERIZER;
+
+	/* if scissor enable bit changed we need to mark scissor
+	 * state as dirty as well:
+	 * NOTE: we can do a shallow compare, since we only care
+	 * if it changed to/from &ctx->disable_scissor
+	 */
+	if (old_scissor != fd_context_get_scissor(ctx))
+		ctx->dirty |= FD_DIRTY_SCISSOR;
 }
 
 static void




More information about the mesa-commit mailing list