Mesa (master): vc4: Drop redundant check for is_tmu_write().

Eric Anholt anholt at kemper.freedesktop.org
Wed Oct 29 00:17:10 UTC 2014


Module: Mesa
Branch: master
Commit: 926ab7dfa54b7f15709455ff4d75746d339ab5a3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=926ab7dfa54b7f15709455ff4d75746d339ab5a3

Author: Eric Anholt <eric at anholt.net>
Date:   Sat Oct 25 12:12:16 2014 +0100

vc4: Drop redundant check for is_tmu_write().

This function is only called when it would return true.

---

 src/gallium/drivers/vc4/kernel/vc4_validate_shaders.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/gallium/drivers/vc4/kernel/vc4_validate_shaders.c b/src/gallium/drivers/vc4/kernel/vc4_validate_shaders.c
index fdce033..03c7f23 100644
--- a/src/gallium/drivers/vc4/kernel/vc4_validate_shaders.c
+++ b/src/gallium/drivers/vc4/kernel/vc4_validate_shaders.c
@@ -94,9 +94,6 @@ check_tmu_write(struct vc4_validated_shader_info *validated_shader,
 {
 	int tmu = waddr > QPU_W_TMU0_B;
 
-	if (!is_tmu_write(waddr))
-		return true;
-
 	if (validation_state->tmu_write_count[tmu] >= 4) {
 		DRM_ERROR("TMU%d got too many parameters before dispatch\n",
 			  tmu);




More information about the mesa-commit mailing list