Mesa (master): i965/fs: Perform CSE on MAD instructions with final arguments switched.

Matt Turner mattst88 at kemper.freedesktop.org
Thu Oct 30 04:34:10 UTC 2014


Module: Mesa
Branch: master
Commit: b65bd9583b9fe0080b5664df2a80d2084499e3c2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b65bd9583b9fe0080b5664df2a80d2084499e3c2

Author: Matt Turner <mattst88 at gmail.com>
Date:   Sun Oct 26 10:08:40 2014 -0700

i965/fs: Perform CSE on MAD instructions with final arguments switched.

Multiplication is commutative.

instructions in affected programs:     48314 -> 47954 (-0.75%)

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_fs_cse.cpp |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp
index 8012001..5fdbf46 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp
@@ -128,7 +128,11 @@ operands_match(fs_inst *a, fs_inst *b)
    fs_reg *xs = a->src;
    fs_reg *ys = b->src;
 
-   if (!is_expression_commutative(a->opcode)) {
+   if (a->opcode == BRW_OPCODE_MAD) {
+      return xs[0].equals(ys[0]) &&
+             ((xs[1].equals(ys[1]) && xs[2].equals(ys[2])) ||
+              (xs[2].equals(ys[1]) && xs[1].equals(ys[2])));
+   } else if (!is_expression_commutative(a->opcode)) {
       bool match = true;
       for (int i = 0; i < a->sources; i++) {
          if (!xs[i].equals(ys[i])) {




More information about the mesa-commit mailing list