Mesa (master): nir: fix bit of cargo-culting in lower_idiv

Rob Clark robclark at kemper.freedesktop.org
Sat Apr 11 16:59:09 UTC 2015


Module: Mesa
Branch: master
Commit: f59613561694cc4a4b81db8a73f8afe893dbacac
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f59613561694cc4a4b81db8a73f8afe893dbacac

Author: Rob Clark <robclark at freedesktop.org>
Date:   Fri Apr 10 16:39:30 2015 -0400

nir: fix bit of cargo-culting in lower_idiv

I guess I was looking too much at how lower_system_values worked when
writing lower_idiv.

Since ttn wasn't emitting load_var for sysvals and the only drivers
using lower_idiv were using ttn, I think nothing was broken as a result.
But might as well fix this before it becomes a problem.

Signed-off-by: Rob Clark <robclark at freedesktop.org>
Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

---

 src/glsl/nir/nir_lower_idiv.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/src/glsl/nir/nir_lower_idiv.c b/src/glsl/nir/nir_lower_idiv.c
index c2f08df..7b68032 100644
--- a/src/glsl/nir/nir_lower_idiv.c
+++ b/src/glsl/nir/nir_lower_idiv.c
@@ -152,6 +152,4 @@ nir_lower_idiv(nir_shader *shader)
       if (overload->impl)
          convert_impl(overload->impl);
    }
-
-   exec_list_make_empty(&shader->system_values);
 }




More information about the mesa-commit mailing list