Mesa (master): nir/validate: Validate that only float ALU outputs are saturated

Jason Ekstrand jekstrand at kemper.freedesktop.org
Tue Feb 3 20:47:46 UTC 2015


Module: Mesa
Branch: master
Commit: 5420774510b565e65d6b2d6c50e76d9ea288348b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5420774510b565e65d6b2d6c50e76d9ea288348b

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Tue Feb  3 12:42:07 2015 -0800

nir/validate: Validate that only float ALU outputs are saturated

Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>

---

 src/glsl/nir/nir_validate.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c
index 7c801b2..89dfdf8 100644
--- a/src/glsl/nir/nir_validate.c
+++ b/src/glsl/nir/nir_validate.c
@@ -239,6 +239,14 @@ validate_alu_dest(nir_alu_dest *dest, validate_state *state)
     * register/SSA value
     */
    assert(is_packed || !(dest->write_mask & ~((1 << dest_size) - 1)));
+
+   /* validate that saturate is only ever used on instructions with
+    * destinations of type float
+    */
+   nir_alu_instr *alu = nir_instr_as_alu(state->instr);
+   assert(nir_op_infos[alu->op].output_type == nir_type_float ||
+          !dest->saturate);
+
    validate_dest(&dest->dest, state);
 }
 




More information about the mesa-commit mailing list