Mesa (master): mesa: Make renderbuffer FBO attachments not layered

Chris Forbes chrisf at kemper.freedesktop.org
Sun Feb 8 00:59:47 UTC 2015


Module: Mesa
Branch: master
Commit: 1581e12aba3712fe4884586c7be6087b0a4a0041
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1581e12aba3712fe4884586c7be6087b0a4a0041

Author: James Legg <lankyleggy at gmail.com>
Date:   Sat Feb  7 23:33:15 2015 +0000

mesa: Make renderbuffer FBO attachments not layered

For framebuffer completeness checks, consider renderbuffers as not
layered. Previously, they would have counted as layered if a layered
textured had previously been bound to the same attachment point. This
could cause framebuffer completeness checks to incorrectly fail with
GL_FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS, even if no layered attachments
were present.

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89026

---

 src/mesa/main/fbobject.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 3305151..dae9d4e 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -468,6 +468,7 @@ set_renderbuffer_attachment(struct gl_context *ctx,
    remove_attachment(ctx, att);
    att->Type = GL_RENDERBUFFER_EXT;
    att->Texture = NULL; /* just to be safe */
+   att->Layered = GL_FALSE;
    att->Complete = GL_FALSE;
    _mesa_reference_renderbuffer(&att->Renderbuffer, rb);
 }




More information about the mesa-commit mailing list