Mesa (master): i965: Move some asserts to unreachable.

Eric Anholt anholt at kemper.freedesktop.org
Fri Feb 13 00:33:52 UTC 2015


Module: Mesa
Branch: master
Commit: f65e26478ba5e20c9cf4ee5d0fcf879ccb4e3c0d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f65e26478ba5e20c9cf4ee5d0fcf879ccb4e3c0d

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Feb 11 14:53:08 2015 -0800

i965: Move some asserts to unreachable.

If execution was supposed to be supported in this case, we'd run into
trouble from completely uninitialized sat_imm values.

v2: Drop the '!' before the string.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/mesa/drivers/dri/i965/brw_shader.cpp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
index 7fc4a84..ad2e22a 100644
--- a/src/mesa/drivers/dri/i965/brw_shader.cpp
+++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
@@ -607,10 +607,10 @@ brw_saturate_immediate(enum brw_reg_type type, struct brw_reg *reg)
    case BRW_REGISTER_TYPE_V:
    case BRW_REGISTER_TYPE_UV:
    case BRW_REGISTER_TYPE_VF:
-      assert(!"unimplemented: saturate vector immediate");
+      unreachable("unimplemented: saturate vector immediate");
    case BRW_REGISTER_TYPE_DF:
    case BRW_REGISTER_TYPE_HF:
-      assert(!"unimplemented: saturate DF/HF immediate");
+      unreachable("unimplemented: saturate DF/HF immediate");
    }
 
    if (imm.ud != sat_imm.ud) {




More information about the mesa-commit mailing list