Mesa (master): nir: Add a flag for lowering fsqrt(x) to frcp(frsqrt(x)).

Eric Anholt anholt at kemper.freedesktop.org
Wed Feb 18 22:57:23 UTC 2015


Module: Mesa
Branch: master
Commit: cb95a228e81a963d77f50058c7406db0ad3bccac
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cb95a228e81a963d77f50058c7406db0ad3bccac

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Jan 28 10:39:29 2015 -0800

nir: Add a flag for lowering fsqrt(x) to frcp(frsqrt(x)).

vc4 cse/algebraic-disabled stats:
total uniforms in shared programs: 13972 -> 13966 (-0.04%)
uniforms in affected programs:     408 -> 402 (-1.47%)
total instructions in shared programs: 44973 -> 44911 (-0.14%)
instructions in affected programs:     1551 -> 1489 (-4.00%)

v2: Rebase to master (no TGSI->NIR present)

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org> (v1)

---

 src/glsl/nir/nir.h                |    1 +
 src/glsl/nir/nir_opt_algebraic.py |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
index bcc51e8..37e15ef 100644
--- a/src/glsl/nir/nir.h
+++ b/src/glsl/nir/nir.h
@@ -1328,6 +1328,7 @@ typedef struct nir_function {
 
 typedef struct nir_shader_compiler_options {
    bool lower_fpow;
+   bool lower_fsqrt;
 } nir_shader_compiler_options;
 
 typedef struct nir_shader {
diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py
index b8b28f1..f93757e 100644
--- a/src/glsl/nir/nir_opt_algebraic.py
+++ b/src/glsl/nir/nir_opt_algebraic.py
@@ -128,7 +128,8 @@ optimizations = [
    (('fdiv', 1.0, a), ('frcp', a)),
    (('frcp', ('frcp', a)), a),
    (('frcp', ('fsqrt', a)), ('frsq', a)),
-   (('frcp', ('frsq', a)), ('fsqrt', a)),
+   (('fsqrt', a), ('frcp', ('frsq', a)), 'options->lower_fsqrt'),
+   (('frcp', ('frsq', a)), ('fsqrt', a), '!options->lower_fsqrt'),
    # Boolean simplifications
    (('ine', 'a at bool', 0), 'a'),
    (('ieq', 'a at bool', 0), ('inot', 'a')),




More information about the mesa-commit mailing list