Mesa (master): vc4: Fix miscalculation of the VPM space.

Eric Anholt anholt at kemper.freedesktop.org
Sat Jan 10 20:01:33 UTC 2015


Module: Mesa
Branch: master
Commit: 06b6a72a3e4a36310cd664aa7e881881aeab146f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=06b6a72a3e4a36310cd664aa7e881881aeab146f

Author: Eric Anholt <eric at anholt.net>
Date:   Sat Jan 10 14:34:16 2015 +1300

vc4: Fix miscalculation of the VPM space.

We pass in a byte offset, not dword.  I'm rather scared that this actually
managed to pass piglit, but it does fix gears.

---

 src/gallium/drivers/vc4/vc4_draw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/vc4/vc4_draw.c b/src/gallium/drivers/vc4/vc4_draw.c
index 77e9821..cc3f2d4 100644
--- a/src/gallium/drivers/vc4/vc4_draw.c
+++ b/src/gallium/drivers/vc4/vc4_draw.c
@@ -214,7 +214,7 @@ vc4_draw_vbo(struct pipe_context *pctx, const struct pipe_draw_info *info)
                 cl_u8(&vc4->shader_rec, vpm_offset); /* VS VPM offset */
                 cl_u8(&vc4->shader_rec, vpm_offset); /* CS VPM offset */
 
-                vpm_offset += align(elem_size, 4) / 4;
+                vpm_offset += align(elem_size, 4);
 
                 if (vb->stride > 0) {
                         max_index = MIN2(max_index,




More information about the mesa-commit mailing list