Mesa (master): freedreno/a3xx,a4xx: silence some warnings

Rob Clark robclark at kemper.freedesktop.org
Tue Mar 3 15:41:16 UTC 2015


Module: Mesa
Branch: master
Commit: 583a8a8f65c3086d21de864c602c6aa6283bcd45
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=583a8a8f65c3086d21de864c602c6aa6283bcd45

Author: Rob Clark <robclark at freedesktop.org>
Date:   Thu Feb 26 21:06:02 2015 -0500

freedreno/a3xx,a4xx: silence some warnings

  fd3_emit.c: In function ‘fd3_emit_vertex_bufs’:
  fd3_emit.c:377:11: warning: unused variable ‘semantic’ [-Wunused-variable]
     uint8_t semantic = sem2name(vp->inputs[i].semantic);

and

  fd4_emit.c: In function ‘fd4_emit_vertex_bufs’:
  fd4_emit.c:304:11: warning: unused variable ‘semantic’ [-Wunused-variable]
     uint8_t semantic = sem2name(vp->inputs[i].semantic);

Signed-off-by: Rob Clark <robclark at freedesktop.org>

---

 src/gallium/drivers/freedreno/a3xx/fd3_emit.c |    3 +--
 src/gallium/drivers/freedreno/a4xx/fd4_emit.c |    4 +---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/gallium/drivers/freedreno/a3xx/fd3_emit.c b/src/gallium/drivers/freedreno/a3xx/fd3_emit.c
index f1a17ec..a5874e4 100644
--- a/src/gallium/drivers/freedreno/a3xx/fd3_emit.c
+++ b/src/gallium/drivers/freedreno/a3xx/fd3_emit.c
@@ -374,8 +374,7 @@ fd3_emit_vertex_bufs(struct fd_ringbuffer *ring, struct fd3_emit *emit)
 		return;
 
 	for (i = 0, j = 0; i <= last; i++) {
-		uint8_t semantic = sem2name(vp->inputs[i].semantic);
-		assert(semantic == 0);
+		assert(sem2name(vp->inputs[i].semantic) == 0);
 		if (vp->inputs[i].compmask) {
 			struct pipe_vertex_element *elem = &vtx->vtx->pipe[i];
 			const struct pipe_vertex_buffer *vb =
diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_emit.c b/src/gallium/drivers/freedreno/a4xx/fd4_emit.c
index 6540e1d..37552cf 100644
--- a/src/gallium/drivers/freedreno/a4xx/fd4_emit.c
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_emit.c
@@ -301,9 +301,7 @@ fd4_emit_vertex_bufs(struct fd_ringbuffer *ring, struct fd4_emit *emit)
 		return;
 
 	for (i = 0, j = 0; i <= last; i++) {
-		uint8_t semantic = sem2name(vp->inputs[i].semantic);
-		assert(semantic != TGSI_SEMANTIC_VERTEXID);
-		assert(semantic != TGSI_SEMANTIC_INSTANCEID);
+		assert(sem2name(vp->inputs[i].semantic) == 0);
 		if (vp->inputs[i].compmask) {
 			struct pipe_vertex_element *elem = &vtx->vtx->pipe[i];
 			const struct pipe_vertex_buffer *vb =




More information about the mesa-commit mailing list