Mesa (10.4): i965/gs: Check newly-generated GS-out VUE map against correct stage
Emil Velikov
evelikov at kemper.freedesktop.org
Wed Mar 4 02:02:53 UTC 2015
Module: Mesa
Branch: 10.4
Commit: 0c46d850d9f154c69258782f219e1705bb90a68c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c46d850d9f154c69258782f219e1705bb90a68c
Author: Chris Forbes <chrisf at ijw.co.nz>
Date: Sat Feb 28 19:57:20 2015 +1300
i965/gs: Check newly-generated GS-out VUE map against correct stage
Previously, we compared our new GS-out VUE map to the existing *VS*-out
VUE map, which is bogus.
This would mostly manifest as redundant dirty flagging where the GS is
in use but the VS and GS output layouts differ; but there is a scary
case where we would fail to flag a GS-out layout change if it happened
to match the VS-out layout.
Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
Cc: "10.5, 10.4" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88885
(cherry picked from commit b51ff50a767cc78d678ed3d2c25995f5c4194fea)
---
src/mesa/drivers/dri/i965/brw_gs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_gs.c b/src/mesa/drivers/dri/i965/brw_gs.c
index f44ac26..fb968cf 100644
--- a/src/mesa/drivers/dri/i965/brw_gs.c
+++ b/src/mesa/drivers/dri/i965/brw_gs.c
@@ -354,7 +354,7 @@ brw_upload_gs_prog(struct brw_context *brw)
}
brw->gs.base.prog_data = &brw->gs.prog_data->base.base;
- if (memcmp(&brw->vs.prog_data->base.vue_map, &brw->vue_map_geom_out,
+ if (memcmp(&brw->gs.prog_data->base.vue_map, &brw->vue_map_geom_out,
sizeof(brw->vue_map_geom_out)) != 0) {
brw->vue_map_geom_out = brw->gs.prog_data->base.vue_map;
brw->state.dirty.brw |= BRW_NEW_VUE_MAP_GEOM_OUT;
More information about the mesa-commit
mailing list