Mesa (master): i965/fs: Apply gl_FrontFacing ? -1 : 1 optimization only for floats
Ian Romanick
idr at kemper.freedesktop.org
Tue Mar 17 22:04:19 UTC 2015
Module: Mesa
Branch: master
Commit: 6db5e134b627d24e3d6d42a6835e6595652c5aab
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6db5e134b627d24e3d6d42a6835e6595652c5aab
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Sat Feb 28 08:32:57 2015 -0800
i965/fs: Apply gl_FrontFacing ? -1 : 1 optimization only for floats
At the very least, unreal4/sun-temple/102.shader_test uses this pattern
for a signed integer result. However, that shader did not hit the
optimization in the first place because it uses !gl_FrontFacing. I
changed the shader to use remove the logical-not and reverse the other
operands. I verified that incorrect code is generated before this
change and correct code is generated after.
Fixes fs-frontfacing-ternary-1-neg-1.shader_test.
No shader-db changes.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index 91dd212..6d56115 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
@@ -2735,6 +2735,9 @@ fs_visitor::try_opt_frontfacing_ternary(ir_if *ir)
if (!then_rhs || !else_rhs)
return false;
+ if (then_rhs->type->base_type != GLSL_TYPE_FLOAT)
+ return false;
+
if ((then_rhs->is_one() && else_rhs->is_negative_one()) ||
(else_rhs->is_one() && then_rhs->is_negative_one())) {
then_assign->lhs->accept(this);
More information about the mesa-commit
mailing list