Mesa (master): gallium/hud: avoid overflowing hud graph name size
Ilia Mirkin
imirkin at kemper.freedesktop.org
Fri Mar 27 01:12:04 UTC 2015
Module: Mesa
Branch: master
Commit: 2e34faaf06f50741164209cc5743ab4d8579c94c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e34faaf06f50741164209cc5743ab4d8579c94c
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Thu Mar 26 19:37:50 2015 -0400
gallium/hud: avoid overflowing hud graph name size
Spotted by Coverity.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
---
src/gallium/auxiliary/hud/hud_driver_query.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_driver_query.c b/src/gallium/auxiliary/hud/hud_driver_query.c
index b48708c..53771fc 100644
--- a/src/gallium/auxiliary/hud/hud_driver_query.c
+++ b/src/gallium/auxiliary/hud/hud_driver_query.c
@@ -157,7 +157,8 @@ hud_pipe_query_install(struct hud_pane *pane, struct pipe_context *pipe,
if (!gr)
return;
- strcpy(gr->name, name);
+ strncpy(gr->name, name, sizeof(gr->name));
+ gr->name[sizeof(gr->name) - 1] = '\0';
gr->query_data = CALLOC_STRUCT(query_info);
if (!gr->query_data) {
FREE(gr);
More information about the mesa-commit
mailing list