Mesa (master): gallium/vl: partially revert "Use util_cpu_to_le{16, 32} in many more places."

Christian König deathsimple at kemper.freedesktop.org
Fri Mar 27 10:34:15 UTC 2015


Module: Mesa
Branch: master
Commit: 787aa26cb7b48504f7770cacfc321324ecafa29a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=787aa26cb7b48504f7770cacfc321324ecafa29a

Author: Christian König <christian.koenig at amd.com>
Date:   Thu Mar 26 14:49:18 2015 +0100

gallium/vl: partially revert "Use util_cpu_to_le{16,32} in many more places."

The data in memory is in big endian format and needs to be converted
into CPU byte order. So the patch actually reversed what needs to be done.

Signed-off-by: Christian König <christian.koenig at amd.com>
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/gallium/auxiliary/vl/vl_vlc.h |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/vl/vl_vlc.h b/src/gallium/auxiliary/vl/vl_vlc.h
index cad9989..2f90595 100644
--- a/src/gallium/auxiliary/vl/vl_vlc.h
+++ b/src/gallium/auxiliary/vl/vl_vlc.h
@@ -149,7 +149,11 @@ vl_vlc_fillbits(struct vl_vlc *vlc)
       } else if (bytes_left >= 4) {
 
          /* enough bytes in buffer, read in a whole dword */
-         uint64_t value = util_cpu_to_le32(*(const uint32_t*)vlc->data);
+         uint64_t value = *(const uint32_t*)vlc->data;
+
+#ifndef PIPE_ARCH_BIG_ENDIAN
+         value = util_bswap32(value);
+#endif
 
          vlc->buffer |= value << vlc->invalid_bits;
          vlc->data += 4;




More information about the mesa-commit mailing list