Mesa (master): st/wgl: add a comment about recursive locking in stw_make_current()

Brian Paul brianp at kemper.freedesktop.org
Thu Nov 12 18:47:01 UTC 2015


Module: Mesa
Branch: master
Commit: 3e74038280319cf02c55f3879d95d7c1aec210fe
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3e74038280319cf02c55f3879d95d7c1aec210fe

Author: Brian Paul <brianp at vmware.com>
Date:   Tue Nov 10 14:49:17 2015 -0700

st/wgl: add a comment about recursive locking in stw_make_current()

Reviewed-by: Sinclair Yeh <syeh at vmware.com>
Reviewed-by: Charmaine Lee <charmainel at vmware.com>

---

 src/gallium/state_trackers/wgl/stw_context.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/gallium/state_trackers/wgl/stw_context.c b/src/gallium/state_trackers/wgl/stw_context.c
index 6387723..5978ca6 100644
--- a/src/gallium/state_trackers/wgl/stw_context.c
+++ b/src/gallium/state_trackers/wgl/stw_context.c
@@ -441,6 +441,10 @@ stw_make_current(HDC hdc, DHGLRC dhglrc)
       /* Bind the new framebuffer */
       ctx->hdc = hdc;
 
+      /* Note: when we call this function we will wind up in the
+       * stw_st_framebuffer_validate_locked() function which will incur
+       * a recursive fb->mutex lock.
+       */
       ret = stw_dev->stapi->make_current(stw_dev->stapi, ctx->st,
                                          fb->stfb, fb->stfb);
       stw_framebuffer_reference(&ctx->current_framebuffer, fb);




More information about the mesa-commit mailing list