Mesa (master): svga: fix incorrect round-down arithmetic

Brian Paul brianp at kemper.freedesktop.org
Mon Oct 19 14:58:00 UTC 2015


Module: Mesa
Branch: master
Commit: 530eb39c71d2f42ef5d6c556aff77c322434f4e2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=530eb39c71d2f42ef5d6c556aff77c322434f4e2

Author: Brian Paul <brianp at vmware.com>
Date:   Mon Oct 19 08:41:37 2015 -0600

svga: fix incorrect round-down arithmetic

Spotted by Roland.  Luckily, this code should never really be hit
since the const buffer size and offset should already be multiples
of 16.  I could probably add more assertions to that effect, but
let's just fix the arithmetic for now.

Reviewed-by: Roland Scheidegger <sroland at vmware.com>

---

 src/gallium/drivers/svga/svga_state_constants.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/svga/svga_state_constants.c b/src/gallium/drivers/svga/svga_state_constants.c
index 75592d3..c93d2a5 100644
--- a/src/gallium/drivers/svga/svga_state_constants.c
+++ b/src/gallium/drivers/svga/svga_state_constants.c
@@ -718,7 +718,7 @@ emit_consts_vgpu10(struct svga_context *svga, unsigned shader)
             /* round down to mulitple of 16 (this may cause rendering problems
              * but should avoid a device error).
              */
-            size &= ~16;
+            size &= ~15;
          }
       }
 




More information about the mesa-commit mailing list