Mesa (master): i965/vec4: Test against BRW_IMMEDIATE_VALUE, not IMM.

Matt Turner mattst88 at kemper.freedesktop.org
Fri Oct 30 00:51:15 UTC 2015


Module: Mesa
Branch: master
Commit: ee46c1e6261584326e9153a22861a16778803506
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ee46c1e6261584326e9153a22861a16778803506

Author: Matt Turner <mattst88 at gmail.com>
Date:   Wed Oct 28 21:19:52 2015 -0700

i965/vec4: Test against BRW_IMMEDIATE_VALUE, not IMM.

No functional change, since they were both 3, but BRW_IMMEDIATE_VALUE is
the hardware value and IMM was the IR value -- and you can see that
BRW_IMMEDIATE_VALUE was correctly used in the context of this patch.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_vec4_generator.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp b/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp
index 586f45e..d74b1b2 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_generator.cpp
@@ -416,7 +416,7 @@ generate_gs_set_write_offset(struct brw_codegen *p,
           src1.file == BRW_IMMEDIATE_VALUE &&
           src1.type == BRW_REGISTER_TYPE_UD &&
           src1.dw1.ud <= USHRT_MAX);
-   if (src0.file == IMM) {
+   if (src0.file == BRW_IMMEDIATE_VALUE) {
       brw_MOV(p, suboffset(stride(dst, 2, 2, 1), 3),
               brw_imm_ud(src0.dw1.ud * src1.dw1.ud));
    } else {




More information about the mesa-commit mailing list