Mesa (master): vc4: Initialize pack field of qreg to 0 in qir_get_temp

Eric Anholt anholt at kemper.freedesktop.org
Fri Sep 4 19:23:18 UTC 2015


Module: Mesa
Branch: master
Commit: 48de40ce9c45de154965490843f9e50407970c26
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=48de40ce9c45de154965490843f9e50407970c26

Author: Boyan Ding <boyan.j.ding at gmail.com>
Date:   Wed Aug 26 19:52:50 2015 +0800

vc4: Initialize pack field of qreg to 0 in qir_get_temp

This avoids generation of undefined packing in qir and qpu instructions,
fixing a lot of rendering errors.

Fixes 8b36d107fdd (vc4: Pack the unorm-packing bits into a src MUL
instruction when possible.)

Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Boyan Ding <boyan.j.ding at gmail.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

---

 src/gallium/drivers/vc4/vc4_qir.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/vc4/vc4_qir.c b/src/gallium/drivers/vc4/vc4_qir.c
index 9d93071..073ba5f 100644
--- a/src/gallium/drivers/vc4/vc4_qir.c
+++ b/src/gallium/drivers/vc4/vc4_qir.c
@@ -314,6 +314,7 @@ qir_get_temp(struct vc4_compile *c)
 
         reg.file = QFILE_TEMP;
         reg.index = c->num_temps++;
+        reg.pack = 0;
 
         if (c->num_temps > c->defs_array_size) {
                 uint32_t old_size = c->defs_array_size;




More information about the mesa-commit mailing list