Mesa (vulkan): gen{7, 8}_pipeline: Always set ViewportXYClipTestEnable

Nanley Chery nchery at kemper.freedesktop.org
Thu Apr 14 01:04:20 UTC 2016


Module: Mesa
Branch: vulkan
Commit: cff0f6b027f139cc33c9ecbfd22f9662d75c0cb7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cff0f6b027f139cc33c9ecbfd22f9662d75c0cb7

Author: Nanley Chery <nanley.g.chery at intel.com>
Date:   Thu Mar 31 23:16:12 2016 -0700

gen{7,8}_pipeline: Always set ViewportXYClipTestEnable

For the following reasons, there is no behavioural change with this
commit: the ViewportXYClipTest function of the CLIP stage will continue
to be enabled outside of Meta (where disable_viewport is always false),
and the CLIP stage is turned off within Meta, so this function will
continue to be disabled in that case.

Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
Reviewed-by: Kristian Høgsberg Kristensen <kristian.h.kristensen at intel.com>

---

 src/intel/vulkan/gen7_pipeline.c | 2 +-
 src/intel/vulkan/gen8_pipeline.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c
index 1039734..5c04fb7 100644
--- a/src/intel/vulkan/gen7_pipeline.c
+++ b/src/intel/vulkan/gen7_pipeline.c
@@ -227,7 +227,7 @@ genX(graphics_pipeline_create)(
       .CullMode                                 = vk_to_gen_cullmode[rs_info->cullMode],
       .ClipEnable                               = !(extra && extra->use_rectlist),
       .APIMode                                  = APIMODE_OGL,
-      .ViewportXYClipTestEnable                 = !(extra && extra->disable_viewport),
+      .ViewportXYClipTestEnable                 = true,
       .ClipMode                                 = CLIPMODE_NORMAL,
       .TriangleStripListProvokingVertexSelect   = 0,
       .LineStripListProvokingVertexSelect       = 0,
diff --git a/src/intel/vulkan/gen8_pipeline.c b/src/intel/vulkan/gen8_pipeline.c
index 0d71e07..7f26ef5 100644
--- a/src/intel/vulkan/gen8_pipeline.c
+++ b/src/intel/vulkan/gen8_pipeline.c
@@ -351,7 +351,7 @@ genX(graphics_pipeline_create)(
                   .ClipEnable = !(extra && extra->use_rectlist),
                   .EarlyCullEnable = true,
                   .APIMode = 1, /* D3D */
-                  .ViewportXYClipTestEnable = !(extra && extra->disable_viewport),
+                  .ViewportXYClipTestEnable = true,
 
                   .ClipMode =
                      pCreateInfo->pRasterizationState->rasterizerDiscardEnable ?




More information about the mesa-commit mailing list