Mesa (vulkan): anv_cmd_buffer: Don't make the initial state dirty

Nanley Chery nchery at kemper.freedesktop.org
Thu Apr 14 01:04:20 UTC 2016


Module: Mesa
Branch: vulkan
Commit: 88d1c19c9dfd6be1a374917f707e3c77089d7013
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=88d1c19c9dfd6be1a374917f707e3c77089d7013

Author: Nanley Chery <nanley.g.chery at intel.com>
Date:   Thu Apr  7 02:47:28 2016 -0700

anv_cmd_buffer: Don't make the initial state dirty

Avoid excessive state emission. Relevant state for an action command
will get set by the user:

>From Chapter 5. Command Buffers,
 When a command buffer begins recording, all state in that command
 buffer is undefined.
 [...]
 Whenever the state of a command buffer is undefined, the application
 must set all relevant state on the command buffer before any state
 dependent commands such as draws and dispatches are recorded, otherwise
 the behavior of executing that command buffer is undefined.

Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
Reviewed-by: Kristian Høgsberg Kristensen <kristian.h.kristensen at intel.com>

---

 src/intel/vulkan/anv_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c
index ac8bf5f..5693fab 100644
--- a/src/intel/vulkan/anv_cmd_buffer.c
+++ b/src/intel/vulkan/anv_cmd_buffer.c
@@ -123,7 +123,7 @@ anv_cmd_state_reset(struct anv_cmd_buffer *cmd_buffer)
    /* 0 isn't a valid config.  This ensures that we always configure L3$. */
    cmd_buffer->state.current_l3_config = 0;
 
-   state->dirty = ~0;
+   state->dirty = 0;
    state->vb_dirty = 0;
    state->descriptors_dirty = 0;
    state->push_constants_dirty = 0;




More information about the mesa-commit mailing list