Mesa (master): nir: only dereference undef after NULL check. (v2)

Dave Airlie airlied at kemper.freedesktop.org
Sun Apr 17 21:38:10 UTC 2016


Module: Mesa
Branch: master
Commit: b3616f13268ac3d4202b175de087bdad2e592173
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3616f13268ac3d4202b175de087bdad2e592173

Author: Dave Airlie <airlied at redhat.com>
Date:   Mon Apr 18 06:56:06 2016 +1000

nir: only dereference undef after NULL check. (v2)

Pointed out by coverity.

v2: nuke line, Jason pointed out the constructor does it.
Signed-off-by: Dave Airlie <airlied at redhat.com>

---

 src/compiler/nir/nir_builder.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h
index 29b13fb..35d65b4 100644
--- a/src/compiler/nir/nir_builder.h
+++ b/src/compiler/nir/nir_builder.h
@@ -79,7 +79,6 @@ nir_ssa_undef(nir_builder *build, unsigned num_components, unsigned bit_size)
 {
    nir_ssa_undef_instr *undef =
       nir_ssa_undef_instr_create(build->shader, num_components, bit_size);
-   undef->def.bit_size = bit_size;
    if (!undef)
       return NULL;
 




More information about the mesa-commit mailing list