Mesa (master): gallivm: fix bogus argument order to lp_build_sample_mipmap function

Roland Scheidegger sroland at kemper.freedesktop.org
Thu Apr 21 21:58:05 UTC 2016


Module: Mesa
Branch: master
Commit: 4ff8cbb0d8c483cc91cad3494cd1db572dcd51ee
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ff8cbb0d8c483cc91cad3494cd1db572dcd51ee

Author: Roland Scheidegger <sroland at vmware.com>
Date:   Thu Apr 21 02:52:35 2016 +0200

gallivm: fix bogus argument order to lp_build_sample_mipmap function

Screwed up since 0753b135f6e83b171d8a1b08aea967374f3542bc.

(Only an issue with different min/mag filters, and then only in some cases,
which is probably why it went unnoticed for quite a while.
The effect should have simply been nearest mip filter instead of linear, iff
min was nearest, mag was linear, and all pixels hit the mignifying path.)

Fixes a bunch of dEQP failures.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

Cc: "11.1 11.2" <mesa-stable at lists.freedesktop.org>

---

 src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
index 83db0ed..1727105 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c
@@ -2256,8 +2256,8 @@ lp_build_sample_general(struct lp_build_sample_context *bld,
              * All pixels require just nearest filtering, which is way
              * cheaper than linear, hence do a separate path for that.
              */
-            lp_build_sample_mipmap(bld, PIPE_TEX_FILTER_NEAREST, FALSE,
-                                   mip_filter_for_nearest,
+            lp_build_sample_mipmap(bld, PIPE_TEX_FILTER_NEAREST,
+                                   mip_filter_for_nearest, FALSE,
                                    coords, offsets,
                                    ilevel0, ilevel1, lod_fpart,
                                    texels);




More information about the mesa-commit mailing list