Mesa (master): st/omx: Fix resource leak on OMX_ErrorNone

Emil Velikov evelikov at kemper.freedesktop.org
Mon Apr 25 14:10:22 UTC 2016


Module: Mesa
Branch: master
Commit: b87856d25d1be1953dea30814994fc40cac5e573
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b87856d25d1be1953dea30814994fc40cac5e573

Author: Robert Foss <robert.foss at collabora.com>
Date:   Thu Apr 21 17:49:20 2016 -0400

st/omx: Fix resource leak on OMX_ErrorNone

Avoid leaking buffer allocated for task if an error has occured.

Coverity id: 1213929
Signed-off-by: Robert Foss <robert.foss at collabora.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

---

 src/gallium/state_trackers/omx/vid_enc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/state_trackers/omx/vid_enc.c b/src/gallium/state_trackers/omx/vid_enc.c
index 4505fe1..de62166 100644
--- a/src/gallium/state_trackers/omx/vid_enc.c
+++ b/src/gallium/state_trackers/omx/vid_enc.c
@@ -1152,6 +1152,7 @@ static OMX_ERRORTYPE vid_enc_EncodeFrame(omx_base_PortType *port, OMX_BUFFERHEAD
       /* ------- load input image into video buffer ---- */
       err = enc_LoadImage(port, buf, task->buf);
       if (err != OMX_ErrorNone)
+         FREE(task);
          return err;
    }
 




More information about the mesa-commit mailing list