Mesa (master): mesa: Disallow CopyTexSubImage on stencil formats in ES.
Kenneth Graunke
kwg at kemper.freedesktop.org
Wed Apr 27 04:35:51 UTC 2016
Module: Mesa
Branch: master
Commit: 027c6c12220f802b39d0dac1ab996e451f95bcf5
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=027c6c12220f802b39d0dac1ab996e451f95bcf5
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Apr 26 02:29:44 2016 -0700
mesa: Disallow CopyTexSubImage on stencil formats in ES.
Fixes
- ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8
- ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
---
src/mesa/main/teximage.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 6ac6fb1..76b6584 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -2530,6 +2530,15 @@ copytexsubimage_error_check(struct gl_context *ctx, GLuint dimensions,
}
}
+ /* In the ES 3.2 specification's Table 8.13 (Valid CopyTexImage source
+ * framebuffer/destination texture base internal format combinations),
+ * all the entries for stencil are left blank (unsupported).
+ */
+ if (_mesa_is_gles(ctx) && _mesa_is_stencil_format(texImage->_BaseFormat)) {
+ _mesa_error(ctx, GL_INVALID_OPERATION, "%s(stencil disallowed)", caller);
+ return GL_TRUE;
+ }
+
/* if we get here, the parameters are OK */
return GL_FALSE;
}
More information about the mesa-commit
mailing list