Mesa (master): tgsi/text: fix parsing of memory instructions
Nicolai Hähnle
nh at kemper.freedesktop.org
Fri Apr 29 16:41:39 UTC 2016
Module: Mesa
Branch: master
Commit: 59af21c3e991d13ffaf79494ea608a67b7d3e7f0
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=59af21c3e991d13ffaf79494ea608a67b7d3e7f0
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Thu Apr 28 17:03:50 2016 -0500
tgsi/text: fix parsing of memory instructions
Properly handle Target and Format parameters when present.
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Dave Airlie <airlied at redhat.com>
---
src/gallium/auxiliary/tgsi/tgsi_text.c | 40 +++++++++++++++++++++++-----------
1 file changed, 27 insertions(+), 13 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c b/src/gallium/auxiliary/tgsi/tgsi_text.c
index c7f1664..ea1ee53 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_text.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_text.c
@@ -1134,23 +1134,37 @@ parse_instruction(
cur = ctx->cur;
eat_opt_white(&cur);
- for (i = 0; inst.Instruction.Memory && *cur == ','; i++) {
- uint j;
+
+ for (; inst.Instruction.Memory && *cur == ',';
+ ctx->cur = cur, eat_opt_white(&cur)) {
+ int j;
+
cur++;
eat_opt_white(&cur);
- ctx->cur = cur;
- for (j = 0; j < 3; j++) {
- if (str_match_nocase_whole(&ctx->cur, tgsi_memory_names[j])) {
- inst.Memory.Qualifier |= 1U << j;
- break;
- }
+
+ j = str_match_name_from_array(&cur, tgsi_memory_names,
+ ARRAY_SIZE(tgsi_memory_names));
+ if (j >= 0) {
+ inst.Memory.Qualifier |= 1U << j;
+ continue;
}
- if (j == 3) {
- report_error(ctx, "Expected memory qualifier");
- return FALSE;
+
+ j = str_match_name_from_array(&cur, tgsi_texture_names,
+ ARRAY_SIZE(tgsi_texture_names));
+ if (j >= 0) {
+ inst.Memory.Texture = j;
+ continue;
}
- cur = ctx->cur;
- eat_opt_white(&cur);
+
+ j = str_match_format(&cur);
+ if (j >= 0) {
+ inst.Memory.Format = j;
+ continue;
+ }
+
+ ctx->cur = cur;
+ report_error(ctx, "Expected memory qualifier, texture target, or format\n");
+ return FALSE;
}
cur = ctx->cur;
More information about the mesa-commit
mailing list