Mesa (master): Re-apply "glsl: don' t try to lower non-gl builtins as if they were gl_FragData"
Marek Olšák
mareko at kemper.freedesktop.org
Wed Aug 10 13:45:34 UTC 2016
Module: Mesa
Branch: master
Commit: bc5df3b321c5393b2f10115cfa5acc8f11bd7146
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bc5df3b321c5393b2f10115cfa5acc8f11bd7146
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Fri Jul 1 19:10:36 2016 -0400
Re-apply "glsl: don't try to lower non-gl builtins as if they were gl_FragData"
If a shader has an output array, it will get treated as though it were
gl_FragData and rewritten into gl_out_FragData instances. We only want
this to happen on the actual gl_FragData and not everything else.
This is a small part of the problem pointed out by the below bug.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96765
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/compiler/glsl/opt_dead_builtin_varyings.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/opt_dead_builtin_varyings.cpp b/src/compiler/glsl/opt_dead_builtin_varyings.cpp
index 33648d7..900a096 100644
--- a/src/compiler/glsl/opt_dead_builtin_varyings.cpp
+++ b/src/compiler/glsl/opt_dead_builtin_varyings.cpp
@@ -85,7 +85,8 @@ public:
{
ir_variable *var = ir->variable_referenced();
- if (!var || var->data.mode != this->mode || !var->type->is_array())
+ if (!var || var->data.mode != this->mode || !var->type->is_array() ||
+ !is_gl_identifier(var->name))
return visit_continue;
/* Only match gl_FragData[], not gl_SecondaryFragDataEXT[] */
More information about the mesa-commit
mailing list