Mesa (master): svga: remove unneeded memset() call in draw_vgpu10()

Brian Paul brianp at kemper.freedesktop.org
Tue Aug 16 14:29:09 UTC 2016


Module: Mesa
Branch: master
Commit: dcf2126f90a1daf226417bde71a62ccf0305adea
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dcf2126f90a1daf226417bde71a62ccf0305adea

Author: Brian Paul <brianp at vmware.com>
Date:   Mon Aug  1 16:31:13 2016 -0600

svga: remove unneeded memset() call in draw_vgpu10()

All three fields of the vbuffer_attrs[] array are assigned in the following
loop.  The remaining elements of the array are not used.

Tested with full Piglit run, Heaven 4.0, etc.

Reviewed-by: Charmaine Lee <charmainel at vmware.com>

---

 src/gallium/drivers/svga/svga_draw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_draw.c b/src/gallium/drivers/svga/svga_draw.c
index 14a7406..9d3f9ef 100644
--- a/src/gallium/drivers/svga/svga_draw.c
+++ b/src/gallium/drivers/svga/svga_draw.c
@@ -533,11 +533,10 @@ draw_vgpu10(struct svga_hwtnl *hwtnl,
    {
       SVGA3dVertexBuffer vbuffer_attrs[PIPE_MAX_ATTRIBS];
 
-      memset(vbuffer_attrs, 0, sizeof(vbuffer_attrs));
-
       for (i = 0; i < vbuf_count; i++) {
          vbuffer_attrs[i].stride = hwtnl->cmd.vbufs[i].stride;
          vbuffer_attrs[i].offset = hwtnl->cmd.vbufs[i].buffer_offset;
+         vbuffer_attrs[i].sid = 0;
       }
 
       /* If we haven't yet emitted a drawing command or if any




More information about the mesa-commit mailing list