Mesa (master): i965: remove unnecessary `if`

Emil Velikov evelikov at kemper.freedesktop.org
Wed Aug 24 10:17:29 UTC 2016


Module: Mesa
Branch: master
Commit: 253274351f550c428ca4f4f21d9b176579f002ee
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=253274351f550c428ca4f4f21d9b176579f002ee

Author: Eric Engestrom <eric.engestrom at imgtec.com>
Date:   Mon Aug 15 15:51:20 2016 +0100

i965: remove unnecessary `if`

if (x) return true; else return false;
can be simplified as:
	return x;
since both `x` are already boolean expressions.

Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

---

 src/mesa/drivers/dri/i965/intel_screen.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
index 9df888d..7876652 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b/src/mesa/drivers/dri/i965/intel_screen.c
@@ -603,13 +603,9 @@ intel_query_image(__DRIimage *image, int attrib, int *value)
       *value = image->planar_format->components;
       return true;
    case __DRI_IMAGE_ATTRIB_FD:
-      if (drm_intel_bo_gem_export_to_prime(image->bo, value) == 0)
-         return true;
-      return false;
+      return !drm_intel_bo_gem_export_to_prime(image->bo, value);
    case __DRI_IMAGE_ATTRIB_FOURCC:
-      if (intel_lookup_fourcc(image->dri_format, value))
-         return true;
-      return false;
+      return intel_lookup_fourcc(image->dri_format, value);
    case __DRI_IMAGE_ATTRIB_NUM_PLANES:
       *value = 1;
       return true;




More information about the mesa-commit mailing list