Mesa (master): radeonsi: don't use allocas for arrays with LLVM 3.8

Marek Olšák mareko at kemper.freedesktop.org
Thu Aug 25 19:20:00 UTC 2016


Module: Mesa
Branch: master
Commit: a491b9e945423a81f785220b85a9b395060952aa
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a491b9e945423a81f785220b85a9b395060952aa

Author: Marek Olšák <marek.olsak at amd.com>
Date:   Thu Aug 25 20:22:59 2016 +0200

radeonsi: don't use allocas for arrays with LLVM 3.8

It crashes.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97413

---

 src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
index 71f52fd..4643e6d 100644
--- a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
+++ b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
@@ -559,8 +559,10 @@ static void emit_declaration(struct lp_build_tgsi_context *bld_base,
 			 * FIXME: We shouldn't need to have the non-alloca
 			 * code path for arrays. LLVM should be smart enough to
 			 * promote allocas into registers when profitable.
+			 *
+			 * LLVM 3.8 crashes with this.
 			 */
-			if (array_size > 16) {
+			if (HAVE_LLVM >= 0x0309 && array_size > 16) {
 				array_alloca = LLVMBuildAlloca(builder,
 					LLVMArrayType(bld_base->base.vec_type,
 						      array_size), "array");




More information about the mesa-commit mailing list