Mesa (master): svga: simplify surface propagation code in svga_set_framebuffer_state()
Brian Paul
brianp at kemper.freedesktop.org
Fri Aug 26 20:32:33 UTC 2016
Module: Mesa
Branch: master
Commit: 1a10b37ac3ff7adaf8e876a893cbd6fa0486426f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1a10b37ac3ff7adaf8e876a893cbd6fa0486426f
Author: Brian Paul <brianp at vmware.com>
Date: Thu Aug 25 18:08:07 2016 -0600
svga: simplify surface propagation code in svga_set_framebuffer_state()
Rewrite the comment too.
Reviewed-by: Neha Bhende <bhenden at vmware.com>
---
src/gallium/drivers/svga/svga_pipe_misc.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_pipe_misc.c b/src/gallium/drivers/svga/svga_pipe_misc.c
index a26e577..7160154 100644
--- a/src/gallium/drivers/svga/svga_pipe_misc.c
+++ b/src/gallium/drivers/svga/svga_pipe_misc.c
@@ -108,7 +108,6 @@ static void svga_set_framebuffer_state(struct pipe_context *pipe,
{
struct svga_context *svga = svga_context(pipe);
struct pipe_framebuffer_state *dst = &svga->curr.framebuffer;
- boolean propagate = FALSE;
unsigned i;
/* make sure any pending drawing calls are flushed before changing
@@ -120,22 +119,15 @@ static void svga_set_framebuffer_state(struct pipe_context *pipe,
dst->height = fb->height;
dst->nr_cbufs = fb->nr_cbufs;
- /* check if we need to propagate any of the target surfaces */
+ /* Check if we need to propagate any of the render targets which we may
+ * be unbinding.
+ */
for (i = 0; i < dst->nr_cbufs; i++) {
struct pipe_surface *s = i < fb->nr_cbufs ? fb->cbufs[i] : NULL;
if (dst->cbufs[i] && dst->cbufs[i] != s) {
if (svga_surface_needs_propagation(dst->cbufs[i])) {
- propagate = TRUE;
- break;
- }
- }
- }
-
- if (propagate) {
- for (i = 0; i < dst->nr_cbufs; i++) {
- struct pipe_surface *s = i < fb->nr_cbufs ? fb->cbufs[i] : NULL;
- if (dst->cbufs[i] && dst->cbufs[i] != s)
svga_propagate_surface(svga, dst->cbufs[i]);
+ }
}
}
More information about the mesa-commit
mailing list