Mesa (master): glsl: Initialize outputs[] array in lower_blend_equation_advanced.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Aug 30 20:11:18 UTC 2016


Module: Mesa
Branch: master
Commit: 66994036517d2cfe4882fc6bf6a6b32649dda5b1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=66994036517d2cfe4882fc6bf6a6b32649dda5b1

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sun Aug 28 21:43:54 2016 -0700

glsl: Initialize outputs[] array in lower_blend_equation_advanced.

Caught by Coverity.  Likely fixes real issues if an output component
is not present.

CID: 1372278
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

---

 src/compiler/glsl/lower_blend_equation_advanced.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/glsl/lower_blend_equation_advanced.cpp b/src/compiler/glsl/lower_blend_equation_advanced.cpp
index a998df1..1d03392 100644
--- a/src/compiler/glsl/lower_blend_equation_advanced.cpp
+++ b/src/compiler/glsl/lower_blend_equation_advanced.cpp
@@ -497,7 +497,7 @@ lower_blend_equation_advanced(struct gl_linked_shader *sh)
     * which writes a subset of the components, starting at location_frac.
     * The variables can't overlap, thankfully.
     */
-   ir_variable *outputs[4];
+   ir_variable *outputs[4] = { NULL, NULL, NULL, NULL };
    foreach_in_list(ir_instruction, ir, sh->ir) {
       ir_variable *var = ir->as_variable();
       if (!var || var->data.mode != ir_var_shader_out)




More information about the mesa-commit mailing list