Mesa (master): anv/descriptor_set: memset anv_descriptor_set_layout

Jason Ekstrand jekstrand at kemper.freedesktop.org
Tue Aug 30 22:49:04 UTC 2016


Module: Mesa
Branch: master
Commit: d316cec1c1e3a77f63332f99883ffeeeb21a6f5e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d316cec1c1e3a77f63332f99883ffeeeb21a6f5e

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Thu Aug 25 02:37:19 2016 -0700

anv/descriptor_set: memset anv_descriptor_set_layout

We hash this data structure so we can't afford to have uninitialized data
even if it is just structure padding.

Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
Cc: "12.0" <mesa-stable at lists.freedesktop.org>

---

 src/intel/vulkan/anv_descriptor_set.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c
index cf1fe15..4ab1802 100644
--- a/src/intel/vulkan/anv_descriptor_set.c
+++ b/src/intel/vulkan/anv_descriptor_set.c
@@ -67,9 +67,8 @@ VkResult anv_CreateDescriptorSetLayout(
    struct anv_sampler **samplers =
       (struct anv_sampler **)&set_layout->binding[max_binding + 1];
 
+   memset(set_layout, 0, sizeof(*set_layout));
    set_layout->binding_count = max_binding + 1;
-   set_layout->shader_stages = 0;
-   set_layout->size = 0;
 
    for (uint32_t b = 0; b <= max_binding; b++) {
       /* Initialize all binding_layout entries to -1 */




More information about the mesa-commit mailing list