Mesa (master): glsl: Handle patch qualifier on interface blocks.
Kenneth Graunke
kwg at kemper.freedesktop.org
Wed Aug 31 05:11:52 UTC 2016
Module: Mesa
Branch: master
Commit: d82f8d9772813949d0f5455cd0edad9003be0fb0
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d82f8d9772813949d0f5455cd0edad9003be0fb0
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Wed Jun 1 19:27:02 2016 -0700
glsl: Handle patch qualifier on interface blocks.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
---
src/compiler/glsl/ast_to_hir.cpp | 4 ++++
src/compiler/glsl/glsl_parser.yy | 11 +++++++++++
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
3 files changed, 16 insertions(+)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 581367b..6e9c32e 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -7498,10 +7498,12 @@ ast_interface_block::hir(exec_list *instructions,
_mesa_glsl_error(&loc, state, "geometry shader inputs must be arrays");
} else if ((state->stage == MESA_SHADER_TESS_CTRL ||
state->stage == MESA_SHADER_TESS_EVAL) &&
+ !this->layout.flags.q.patch &&
this->array_specifier == NULL &&
var_mode == ir_var_shader_in) {
_mesa_glsl_error(&loc, state, "per-vertex tessellation shader inputs must be arrays");
} else if (state->stage == MESA_SHADER_TESS_CTRL &&
+ !this->layout.flags.q.patch &&
this->array_specifier == NULL &&
var_mode == ir_var_shader_out) {
_mesa_glsl_error(&loc, state, "tessellation control shader outputs must be arrays");
@@ -7617,6 +7619,8 @@ ast_interface_block::hir(exec_list *instructions,
if (var_mode == ir_var_shader_in || var_mode == ir_var_uniform)
var->data.read_only = true;
+ var->data.patch = this->layout.flags.q.patch;
+
if (state->stage == MESA_SHADER_GEOMETRY && var_mode == ir_var_shader_in)
handle_geometry_shader_input_decl(state, loc, var);
else if ((state->stage == MESA_SHADER_TESS_CTRL ||
diff --git a/src/compiler/glsl/glsl_parser.yy b/src/compiler/glsl/glsl_parser.yy
index 3f35b2f..9e1fd9e 100644
--- a/src/compiler/glsl/glsl_parser.yy
+++ b/src/compiler/glsl/glsl_parser.yy
@@ -2758,6 +2758,17 @@ interface_qualifier:
memset(& $$, 0, sizeof($$));
$$.flags.q.buffer = 1;
}
+ | auxiliary_storage_qualifier interface_qualifier
+ {
+ if (!$1.flags.q.patch) {
+ _mesa_glsl_error(&@1, state, "invalid interface qualifier");
+ }
+ if ($2.has_auxiliary_storage()) {
+ _mesa_glsl_error(&@1, state, "duplicate patch qualifier");
+ }
+ $$ = $2;
+ $$.flags.q.patch = 1;
+ }
;
instance_name_opt:
diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl/glsl_parser_extras.cpp
index b33cd3a..436ddd0 100644
--- a/src/compiler/glsl/glsl_parser_extras.cpp
+++ b/src/compiler/glsl/glsl_parser_extras.cpp
@@ -959,6 +959,7 @@ _mesa_ast_process_interface_block(YYLTYPE *locp,
temp_type_qualifier.flags.q.in = true;
temp_type_qualifier.flags.q.out = true;
temp_type_qualifier.flags.q.buffer = true;
+ temp_type_qualifier.flags.q.patch = true;
interface_type_mask = temp_type_qualifier.flags.i;
/* Get the block's interface qualifier. The interface_qualifier
More information about the mesa-commit
mailing list