Mesa (master): mesa: recognize enums GL_COLOR_ATTACHMENT8-31 as valid
Ilia Mirkin
imirkin at kemper.freedesktop.org
Fri Feb 12 23:25:03 UTC 2016
Module: Mesa
Branch: master
Commit: b7e246d89afb2c6072fd65f6bf01a1921afc6d2a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b7e246d89afb2c6072fd65f6bf01a1921afc6d2a
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Fri Feb 12 13:12:09 2016 -0500
mesa: recognize enums GL_COLOR_ATTACHMENT8-31 as valid
Similar as for AUX1-3, these enums aren't invalid (i.e. -1) but also not
supported by mesa. Returning BUFFER_COUNT causes the proper error to be
returned by ReadBuffer and other functions. This resolves some failures
in
dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.read_buffer
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Brian Paul <brianp at vmware.com>
---
src/mesa/main/buffers.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c
index 83e238a..3ca4b66 100644
--- a/src/mesa/main/buffers.c
+++ b/src/mesa/main/buffers.c
@@ -159,6 +159,9 @@ draw_buffer_enum_to_bitmask(const struct gl_context *ctx, GLenum buffer)
case GL_COLOR_ATTACHMENT7_EXT:
return BUFFER_BIT_COLOR7;
default:
+ /* not an error, but also not supported */
+ if (buffer >= GL_COLOR_ATTACHMENT8 && buffer <= GL_COLOR_ATTACHMENT31)
+ return 1 << BUFFER_COUNT;
/* error */
return BAD_MASK;
}
@@ -214,6 +217,9 @@ read_buffer_enum_to_index(GLenum buffer)
case GL_COLOR_ATTACHMENT7_EXT:
return BUFFER_COLOR7;
default:
+ /* not an error, but also not supported */
+ if (buffer >= GL_COLOR_ATTACHMENT8 && buffer <= GL_COLOR_ATTACHMENT31)
+ return BUFFER_COUNT;
/* error */
return -1;
}
More information about the mesa-commit
mailing list