Mesa (vulkan): anv/gen7: Clean up the dummy PS case

Jason Ekstrand jekstrand at kemper.freedesktop.org
Sat Feb 27 19:25:16 UTC 2016


Module: Mesa
Branch: vulkan
Commit: 46b7c242da7c7c9ea7877a2c4b1fecdf5c1c0452
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=46b7c242da7c7c9ea7877a2c4b1fecdf5c1c0452

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Sat Feb 27 09:46:40 2016 -0800

anv/gen7: Clean up the dummy PS case

Fix whitespace and remove dead comments

---

 src/intel/vulkan/gen7_pipeline.c | 32 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 19 deletions(-)

diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c
index 2167f29..7151e36 100644
--- a/src/intel/vulkan/gen7_pipeline.c
+++ b/src/intel/vulkan/gen7_pipeline.c
@@ -323,27 +323,21 @@ genX(graphics_pipeline_create)(
    }
 
    if (pipeline->ps_ksp0 == NO_KERNEL) {
-     anv_finishme("disabling ps");
+      anv_batch_emit(&pipeline->batch, GENX(3DSTATE_SBE));
 
-     /* FIXME: generated header doesn't emit attr swizzle fields */
-     anv_batch_emit(&pipeline->batch, GENX(3DSTATE_SBE));
-
-     /* FIXME-GEN7: This needs a lot more work, cf gen7 upload_wm_state(). */
-     anv_batch_emit(&pipeline->batch, GENX(3DSTATE_WM),
-		    .StatisticsEnable                         = true,
-		    .ThreadDispatchEnable                     = false,
-		    .LineEndCapAntialiasingRegionWidth        = 0, /* 0.5 pixels */
-		    .LineAntialiasingRegionWidth              = 1, /* 1.0 pixels */
-		    .EarlyDepthStencilControl                 = EDSC_NORMAL,
-		    .PointRasterizationRule                   = RASTRULE_UPPER_RIGHT);
-
-
-     /* Even if no fragments are ever dispatched, the hardware hangs if we
-      * don't at least set the maximum number of threads.
-      */
-     anv_batch_emit(&pipeline->batch, GENX(3DSTATE_PS),
-                    .MaximumNumberofThreads                   = device->info.max_wm_threads - 1);
+      anv_batch_emit(&pipeline->batch, GENX(3DSTATE_WM),
+                     .StatisticsEnable                         = true,
+                     .ThreadDispatchEnable                     = false,
+                     .LineEndCapAntialiasingRegionWidth        = 0, /* 0.5 pixels */
+                     .LineAntialiasingRegionWidth              = 1, /* 1.0 pixels */
+                     .EarlyDepthStencilControl                 = EDSC_NORMAL,
+                     .PointRasterizationRule                   = RASTRULE_UPPER_RIGHT);
 
+      /* Even if no fragments are ever dispatched, the hardware hangs if we
+       * don't at least set the maximum number of threads.
+       */
+      anv_batch_emit(&pipeline->batch, GENX(3DSTATE_PS),
+                     .MaximumNumberofThreads                   = device->info.max_wm_threads - 1);
    } else {
       const struct brw_wm_prog_data *wm_prog_data = &pipeline->wm_prog_data;
       if (wm_prog_data->urb_setup[VARYING_SLOT_BFC0] != -1 ||




More information about the mesa-commit mailing list