Mesa (master): vc4: Mark texturing setup instructions as having side effects.

Eric Anholt anholt at kemper.freedesktop.org
Mon Jul 4 23:38:50 UTC 2016


Module: Mesa
Branch: master
Commit: 2a8973fb78026b830786aa74b07805730ae891ca
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a8973fb78026b830786aa74b07805730ae891ca

Author: Eric Anholt <eric at anholt.net>
Date:   Fri Jun  3 15:04:57 2016 -0700

vc4: Mark texturing setup instructions as having side effects.

We need to not DCE them even though they don't have a destination in QIR.
We also shouldn't relocate them in vc4_opt_vpm.  Neither of these things
happen, but I'm about to make DCE consider instructions with a NULL
destination.

---

 src/gallium/drivers/vc4/vc4_qir.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/gallium/drivers/vc4/vc4_qir.c b/src/gallium/drivers/vc4/vc4_qir.c
index b9676ad..4cdc8a2 100644
--- a/src/gallium/drivers/vc4/vc4_qir.c
+++ b/src/gallium/drivers/vc4/vc4_qir.c
@@ -75,11 +75,11 @@ static const struct qir_op_info qir_op_info[] = {
         [QOP_FRAG_Z] = { "frag_z", 1, 0 },
         [QOP_FRAG_W] = { "frag_w", 1, 0 },
 
-        [QOP_TEX_S] = { "tex_s", 0, 2 },
-        [QOP_TEX_T] = { "tex_t", 0, 2 },
-        [QOP_TEX_R] = { "tex_r", 0, 2 },
-        [QOP_TEX_B] = { "tex_b", 0, 2 },
-        [QOP_TEX_DIRECT] = { "tex_direct", 0, 2 },
+        [QOP_TEX_S] = { "tex_s", 0, 2, true },
+        [QOP_TEX_T] = { "tex_t", 0, 2, true },
+        [QOP_TEX_R] = { "tex_r", 0, 2, true },
+        [QOP_TEX_B] = { "tex_b", 0, 2, true },
+        [QOP_TEX_DIRECT] = { "tex_direct", 0, 2, true },
         [QOP_TEX_RESULT] = { "tex_result", 1, 0, true },
 
         [QOP_LOAD_IMM] = { "load_imm", 0, 1 },




More information about the mesa-commit mailing list