Mesa (master): nir/spirv: Don't multiply the push constant block size by 4
Jason Ekstrand
jekstrand at kemper.freedesktop.org
Wed Jul 13 18:44:46 UTC 2016
Module: Mesa
Branch: master
Commit: 49476576ddd5c743b852bb2c1ad75ebfe3e1c72d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=49476576ddd5c743b852bb2c1ad75ebfe3e1c72d
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Wed Jul 13 11:35:29 2016 -0700
nir/spirv: Don't multiply the push constant block size by 4
I have no idea why we were multiplying by 4 before. The offsets we get
from SPIR-V are in bytes and so is nir->num_uniforms so there's no need to
do any adjustment whatsoever.
Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
Cc: "12.0" <mesa-stable at lists.freedesktop.org>
---
src/compiler/spirv/vtn_variables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c
index fe2494b..8b112b0 100644
--- a/src/compiler/spirv/vtn_variables.c
+++ b/src/compiler/spirv/vtn_variables.c
@@ -1173,7 +1173,7 @@ vtn_handle_variables(struct vtn_builder *b, SpvOp opcode,
case SpvStorageClassPushConstant:
var->mode = vtn_variable_mode_push_constant;
assert(b->shader->num_uniforms == 0);
- b->shader->num_uniforms = vtn_type_block_size(var->type) * 4;
+ b->shader->num_uniforms = vtn_type_block_size(var->type);
break;
case SpvStorageClassInput:
var->mode = vtn_variable_mode_input;
More information about the mesa-commit
mailing list