Mesa (master): ddebug: use pclose to close a popen()'d FILE

Nicolai Hähnle nh at kemper.freedesktop.org
Thu Jul 28 10:03:29 UTC 2016


Module: Mesa
Branch: master
Commit: bade0cd0fbbf8004626e485806973d18f493749a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bade0cd0fbbf8004626e485806973d18f493749a

Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date:   Wed Jul 27 16:48:07 2016 +0200

ddebug: use pclose to close a popen()'d FILE

Found by Coverity.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

---

 src/gallium/drivers/ddebug/dd_draw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c
index a54cecb..d3c4e7f 100644
--- a/src/gallium/drivers/ddebug/dd_draw.c
+++ b/src/gallium/drivers/ddebug/dd_draw.c
@@ -70,7 +70,7 @@ dd_dump_dmesg(FILE *f)
    while (fgets(line, sizeof(line), p))
       fputs(line, f);
 
-   fclose(p);
+   pclose(p);
 }
 
 static void




More information about the mesa-commit mailing list