Mesa (master): nir/spirv: Use breaks instead of returns in constant handling

Jason Ekstrand jekstrand at kemper.freedesktop.org
Sat Jun 4 02:29:48 UTC 2016


Module: Mesa
Branch: master
Commit: b26cdd65e8e588ed7bdd7cca0b205579132e1261
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b26cdd65e8e588ed7bdd7cca0b205579132e1261

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Wed Jun  1 10:34:04 2016 -0700

nir/spirv: Use breaks instead of returns in constant handling

Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Cc: "12.0" <mesa-stable at lists.freedesktop.org>

---

 src/compiler/spirv/spirv_to_nir.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index 4061b8a..bb7aba4 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -1028,7 +1028,7 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
                val->constant->value.u[i] = u[comp];
             }
          }
-         return;
+         break;
       }
 
       case SpvOpCompositeExtract:
@@ -1105,7 +1105,7 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
                   (*c)->value.u[elem + i] = insert->constant->value.u[i];
             }
          }
-         return;
+         break;
       }
 
       default: {
@@ -1134,9 +1134,10 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
          for (unsigned k = 0; k < num_components; k++)
             val->constant->value.u[k] = res.u32[k];
 
-         return;
+         break;
       } /* default */
       }
+      break;
    }
 
    case SpvOpConstantNull:




More information about the mesa-commit mailing list