Mesa (master): anv/formats: Make alpha blending a property of render targets

Nanley Chery nchery at kemper.freedesktop.org
Tue May 24 00:26:30 UTC 2016


Module: Mesa
Branch: master
Commit: 2ae493d68647af26c64ae59f0127349d75817b91
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ae493d68647af26c64ae59f0127349d75817b91

Author: Nanley Chery <nanley.g.chery at intel.com>
Date:   Tue May  3 10:08:44 2016 -0700

anv/formats: Make alpha blending a property of render targets

In agreement with the SNB PRM, alpha blending is a property that render
targets may or may not support.

Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

---

 src/intel/vulkan/anv_formats.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index a920ab4..a0fa976 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -329,11 +329,9 @@ get_image_format_properties(int gen, enum isl_format base,
        format.swizzle.a == ISL_CHANNEL_SELECT_ALPHA) {
       flags |= VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT |
                VK_FORMAT_FEATURE_BLIT_DST_BIT;
-   }
 
-   if (info->alpha_blend <= gen &&
-       format.swizzle.a == ISL_CHANNEL_SELECT_ALPHA) {
-      flags |= VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT;
+      if (info->alpha_blend <= gen)
+         flags |= VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT;
    }
 
    /* Load/store is determined based on base format.  This prevents RGB




More information about the mesa-commit mailing list