Mesa (master): util: Fix Clang trivial destructor check.
Vinson Lee
vlee at kemper.freedesktop.org
Wed Nov 16 01:32:09 UTC 2016
Module: Mesa
Branch: master
Commit: ed6694d5114e81cf1c413aec8265ddc8a5c52599
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ed6694d5114e81cf1c413aec8265ddc8a5c52599
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sun Nov 13 22:53:54 2016 -0800
util: Fix Clang trivial destructor check.
Check for Clang before GCC.
Clang defines __GNUC__ == 4 and __GNUC_MINOR__ == 2 and matches the GCC
check but not the GCC version for trivial destructor.
Fixes: 98ab905af0e0 ("mesa: Define introspection macro to determine
whether a type is trivially destructible.")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98526
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
---
src/util/macros.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/util/macros.h b/src/util/macros.h
index 0563fa5..733bf42 100644
--- a/src/util/macros.h
+++ b/src/util/macros.h
@@ -167,12 +167,12 @@ do { \
* performs no action and all member variables and base classes are
* trivially destructible themselves.
*/
-# if defined(__GNUC__)
-# if ((__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 3)))
+# if (defined(__clang__) && defined(__has_feature))
+# if __has_feature(has_trivial_destructor)
# define HAS_TRIVIAL_DESTRUCTOR(T) __has_trivial_destructor(T)
# endif
-# elif (defined(__clang__) && defined(__has_feature))
-# if __has_feature(has_trivial_destructor)
+# elif defined(__GNUC__)
+# if ((__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 3)))
# define HAS_TRIVIAL_DESTRUCTOR(T) __has_trivial_destructor(T)
# endif
# elif defined(_MSC_VER) && !defined(__INTEL_COMPILER)
More information about the mesa-commit
mailing list