Mesa (master): docs/submitting patches: mention get_reviewers.pl
Emil Velikov
evelikov at kemper.freedesktop.org
Tue Nov 22 15:49:54 UTC 2016
Module: Mesa
Branch: master
Commit: a2283b50e68ffb560057e53fa195aa8498246d8c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a2283b50e68ffb560057e53fa195aa8498246d8c
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Mon Nov 21 17:53:33 2016 +0000
docs/submitting patches: mention get_reviewers.pl
Mention the script - why/how to use alongside a useful trick to make it
work interactively (thanks Rob!).
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Elie Tournier <tournier.elie at gmail.com>
---
docs/submittingpatches.html | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
index d2b605b..2d18c74 100644
--- a/docs/submittingpatches.html
+++ b/docs/submittingpatches.html
@@ -104,6 +104,19 @@ that should be documented with:
Reviewed-by: Joe Hacker <jhacker at foo.com>
Acked-by: Joe Hacker <jhacker at foo.com>
</pre>
+<li>In order for your patch to reach the prospective reviewer easier/faster,
+use the script scripts/get_reviewer.pl to get a list of individuals and include
+them in the CC list.
+<br>
+Please use common sense and do <strong>not</strong> blindly add everyone.
+<br>
+<pre>
+ $ scripts/get_reviewer.pl --help # to get the the help screen
+ $ scripts/get_reviewer.pl -f src/egl/drivers/dri2/platform_android.c
+ Rob Herring <robh at kernel.org> (reviewer:ANDROID EGL SUPPORT,added_lines:188/700=27%,removed_lines:58/283=20%)
+ Tomasz Figa <tfiga at chromium.org> (reviewer:ANDROID EGL SUPPORT,authored:12/41=29%,added_lines:308/700=44%,removed_lines:115/283=41%)
+ Emil Velikov <emil.l.velikov at gmail.com> (authored:13/41=32%,removed_lines:76/283=27%)
+</pre>
</ul>
@@ -335,6 +348,11 @@ commits before sending.
git send-email --subject-prefix="PATCH v4" HEAD~8
git send-email -v4 @~8 # shorter version, inherited from git format-patch
</pre>
+<li> Configure git to use the get_reviewer.pl script interactively. Thus you
+can avoid adding the world to the CC list.
+<pre>
+ git config sendemail.cccmd "./scripts/get_reviewer.pl -i"
+</pre>
</ul>
More information about the mesa-commit
mailing list