Mesa (master): anv: fix segfault in anv_BindImageMemory

Dave Airlie airlied at kemper.freedesktop.org
Wed Nov 23 06:11:52 UTC 2016


Module: Mesa
Branch: master
Commit: 9ce592647682b1d27c313c4f72713046fc86cbe4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9ce592647682b1d27c313c4f72713046fc86cbe4

Author: Dave Airlie <airlied at redhat.com>
Date:   Wed Nov 23 16:05:34 2016 +1000

anv: fix segfault in anv_BindImageMemory

Since bind image memory started memsetting surfaces, the
device node can't be NULL, since we lookup device->info.has_llc.

Not sure why it ever was NULL before.

Fixes some things on my Ivybridge.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Signed-off-by: Dave Airlie <airlied at redhat.com>

---

 src/intel/vulkan/anv_wsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c
index c504658..669eacc 100644
--- a/src/intel/vulkan/anv_wsi.c
+++ b/src/intel/vulkan/anv_wsi.c
@@ -200,7 +200,7 @@ x11_anv_wsi_image_create(VkDevice device_h,
    memory = anv_device_memory_from_handle(memory_h);
    memory->bo.is_winsys_bo = true;
 
-   anv_BindImageMemory(VK_NULL_HANDLE, image_h, memory_h, 0);
+   anv_BindImageMemory(device_h, image_h, memory_h, 0);
 
    struct anv_surface *surface = &image->color_surface;
    assert(surface->isl.tiling == ISL_TILING_X);




More information about the mesa-commit mailing list