Mesa (master): egl: Drop duplicate check on EGLSync type
Chad Versace
chadversary at kemper.freedesktop.org
Tue Oct 4 21:12:56 UTC 2016
Module: Mesa
Branch: master
Commit: add01add1bb91af64ad5cfa671c99bee72016773
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=add01add1bb91af64ad5cfa671c99bee72016773
Author: Chad Versace <chadversary at chromium.org>
Date: Tue Sep 27 13:27:19 2016 -0700
egl: Drop duplicate check on EGLSync type
_eglInitSync checked that the display supported the sync type (such as
EGL_SYNC_FENCE), and did it wrong. When the check failed it emitted
EGL_BAD_ATTRIBUTE, but sometimes EGL_BAD_PARAMETER is needed.
_eglCreateSync already does the error checking, and it does it right.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
---
src/egl/main/eglsync.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c
index 6f77992..afb724f 100644
--- a/src/egl/main/eglsync.c
+++ b/src/egl/main/eglsync.c
@@ -110,12 +110,6 @@ _eglInitSync(_EGLSync *sync, _EGLDisplay *dpy, EGLenum type,
{
EGLint err;
- if (!(type == EGL_SYNC_REUSABLE_KHR && dpy->Extensions.KHR_reusable_sync) &&
- !(type == EGL_SYNC_FENCE_KHR && dpy->Extensions.KHR_fence_sync) &&
- !(type == EGL_SYNC_CL_EVENT_KHR && dpy->Extensions.KHR_cl_event2 &&
- attrib_list64))
- return _eglError(EGL_BAD_ATTRIBUTE, "eglCreateSyncKHR");
-
_eglInitResource(&sync->Resource, sizeof(*sync), dpy);
sync->Type = type;
sync->SyncStatus = EGL_UNSIGNALED_KHR;
More information about the mesa-commit
mailing list