Mesa (master): glsl: prohibit lowp, mediump precision on atomic_uint
Tapani Pälli
tpalli at kemper.freedesktop.org
Mon Oct 10 05:07:56 UTC 2016
Module: Mesa
Branch: master
Commit: d997d5c0c9e9c70a95f0c84255feec8e2963ef20
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d997d5c0c9e9c70a95f0c84255feec8e2963ef20
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Fri Oct 7 08:23:41 2016 +0300
glsl: prohibit lowp, mediump precision on atomic_uint
Fixes following dEQP tests:
dEQP-GLES31.functional.debug.negative_coverage.callbacks.atomic_counter.atomic_precision
dEQP-GLES31.functional.debug.negative_coverage.get_error.atomic_counter.atomic_precision
dEQP-GLES31.functional.debug.negative_coverage.log.atomic_counter.atomic_precision
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98131
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/compiler/glsl/ast_to_hir.cpp | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 8cdb917..c3c8cef 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -2585,6 +2585,20 @@ select_gles_precision(unsigned qual_precision,
type->name);
}
}
+
+
+ /* Section 4.1.7.3 (Atomic Counters) of the GLSL ES 3.10 spec says:
+ *
+ * "The default precision of all atomic types is highp. It is an error to
+ * declare an atomic type with a different precision or to specify the
+ * default precision for an atomic type to be lowp or mediump."
+ */
+ if (type->base_type == GLSL_TYPE_ATOMIC_UINT &&
+ precision != ast_precision_high) {
+ _mesa_glsl_error(loc, state,
+ "atomic_uint can only have highp precision qualifier");
+ }
+
return precision;
}
More information about the mesa-commit
mailing list