Mesa (master): anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

Lionel Landwerlin llandwerlin at kemper.freedesktop.org
Mon Oct 10 08:26:17 UTC 2016


Module: Mesa
Branch: master
Commit: 014bd4acb8b130fb31ec00f6125b8a91881bebdf
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=014bd4acb8b130fb31ec00f6125b8a91881bebdf

Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date:   Fri Oct  7 13:53:04 2016 +0100

anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

According to the Vulkan spec 5.63.4 :

  samplerAnisotropy indicates whether anisotropic filtering is supported. If
  this feature is not enabled, the maxAnisotropy member of the
  VkSamplerCreateInfo structure must be 1.0.

Since we already set maxAnisotropy to 16 and program the hardware according
to the VkSamplerCreateInfo.maxAnisotropy, it seems we can turn this on.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

---

 src/intel/vulkan/TODO         | 1 -
 src/intel/vulkan/anv_device.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
index 9ac63eb..4c3faad 100644
--- a/src/intel/vulkan/TODO
+++ b/src/intel/vulkan/TODO
@@ -5,7 +5,6 @@ Missing Features:
  - FP64
  - Tessellation
  - Cull and Clip Distance
- - Sampler anisotropy (Is there anything to do here?)
  - Image Gather Extended
  - Storage Image Without Format
  - Investigate CTS failures on HSW
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 9f8fa33..02246ba 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -418,7 +418,7 @@ void anv_GetPhysicalDeviceFeatures(
       .largePoints                              = true,
       .alphaToOne                               = true,
       .multiViewport                            = true,
-      .samplerAnisotropy                        = false, /* FINISHME */
+      .samplerAnisotropy                        = true,
       .textureCompressionETC2                   = pdevice->info.gen >= 8 ||
                                                   pdevice->info.is_baytrail,
       .textureCompressionASTC_LDR               = pdevice->info.gen >= 9, /* FINISHME CHV */




More information about the mesa-commit mailing list