Mesa (master): 36 new commits
Emil Velikov
evelikov at kemper.freedesktop.org
Fri Oct 14 14:09:50 UTC 2016
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=284795616a76787447ebf7db8b93d4b90073ccf5
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 15:52:58 2016 +0100
egl/drm: set eglError and provide an error message on failure
v2: Remove gratuitous newline/semicolon (Eric)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d81ba763e38b726054dca5b59671ffa0166461b4
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 15:24:44 2016 +0100
egl/x11: attribute for dri2_add_config failure
... in dri2_x11_add_configs_for_visuals().
Currently the latter does not consider that, thus in such cases it adds
"empty" configs in the list.
Properly account for things and as we do that we can reuse count,
instead of calling _eglGetArraySize to determine if we've added any
configs.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0b2b7191214eb77c5720a40231a6f2d28da63027
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 14:55:06 2016 +0100
egl/wayland: introduce dri2_wl_add_configs_for_visuals() helper
Analogous to previous commits - with an extra bonus.
Current code, apart from not attributing the lack of 'per visual'
and overall configs also overwrites the newly added config.
Namely if the dpy supports two or more of the supported formats
(XRGB8888, ARGB8888 and RGB565) earlier configs will be overwritten
and the the final one will be stored, since the we use the same index
for all three in our dri2_add_config call.
v2: Use correct comparison in loop conditional (Eric)
Use valid C initializer (Gurchetan)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4b8a55809ebb21281017efb81b54a3fbdd0d4b56
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 14:35:39 2016 +0100
egl/surfaceless: tweak surfaceless_add_configs_for_visuals()
Analogous to previous commit.
v2: Use correct comparison in loop conditional (Eric)
Use valid C initializer (Gurchetan)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=acd35c8758dc732409035cb0488c9d1c896f636d
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 14:28:48 2016 +0100
egl/android: tweak droid_add_configs_for_visuals()
Iterate over the driver_configs first in order to cut down the number of
getConfigAttrib() calls by a factor of 5.
While we're here, also drop the sentinel of the visuals array. We
already know its size so we can use that and save a few bytes.
v2: Use correct comparison in loop conditional (Eric)
Use valid C initializer (Gurchetan)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=36fe5900a4c3f098699acd09221ab31b74229580
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 14:00:50 2016 +0100
egl/drm: introduce drm_add_configs_for_visuals() helper
Factor out and rework the existing code so that it prints a debug
message if we have zero configs for any visual.
As a nice side effect we now provide a correct (sequential ID) when
creating a config (via dri2_add_config).
v2: Use correct comparison in loop conditional (Eric)
Use valid C initializer (Gurchetan)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=23ed073aa4f87943f660edaa54b60da5a9f2dbb7
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 13:32:41 2016 +0100
egl/surfaceless: print out a message on zero configs for given format
Currently we print a debug message if the total configs is non-zero only
to do the same (at an error level) as we return from the function.
Rework the message to print if we're missing a config for the given
format.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=98f5d0106a8ee45e58a6bf162720da3f6f614a95
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 13:15:43 2016 +0100
egl/dri2: set WL_bind_wayland_display in a consistent way
Introduce a helper and use it throughout the platform code. This allows
us to reduce the amount of ifdef(s) and (potentially) use
kms_swrast_dri.so for !drm platforms (namely wayland and x11).
Note: in the future as other platforms (android, surfaceless) support
the extension they can reuse the helper.
v2: Rebase, check for device_name.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Daniel Stone <daniels at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=637d001a97a82142bc20d410655098a0b7b39694
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 13:04:18 2016 +0100
egl/android: remove duplicate KHR_image_base set
The core egl/dri2 already sets the extension bit _only_ when possible -
which in Android's case is always.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9caacb39b9f27919a7c986ad0c5d671a81b1f1e0
Author: Emil Velikov <emil.veliikov at collabora.com>
Date: Thu Aug 25 11:08:30 2016 +0100
loader/dri3: constify the loader_dri3_vtable
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fdd373acca4a17093d7973c210174c1a12dd7da1
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 09:51:54 2016 +0100
egl/dri2: micro optimise dri2_bind_extensions()
Do not loop over all matches if we've already found one.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=665cad16580f4660d8e451cfaa8e5a9def27eb1e
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 00:52:36 2016 +0100
egl/dri2: annotate dri2_extension_match instances as const data
v2: Rebase.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3948ad82cec3c04d9cb3e06de5456254d644071e
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 00:51:05 2016 +0100
egl/dri2: use dri2_bind_extensions to manage the optional extensions
v2: dri2_bind_extensions() now takes optional as an argument.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d5342c6ff241419e287700e4c4e7c1043fd48ffc
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 00:42:56 2016 +0100
gbm: rename gbm_dri_device::{,loader_}extensions
To align with the name used in the EGL and GLX loaders.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=38526bd4688a10385df1963458e8c6aded552653
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 00:16:01 2016 +0100
egl/dri2: add support for optional extensions in dri2_bind_extensions()
Will allow us to reuse the function for optional extensions and fold a
bit of code.
v2: Make dri2_bind_extensions::optional flag an argument to
dri2_bind_extensions (Kristian).
Cc: Rob Clark <robdclark at gmail.com>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ebc68e38491b7bea61e964521d41ba6b2a127546
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 25 00:12:13 2016 +0100
egl/dri2: coding style cleanup
Consistently indent with space rather than a mix of tab and
spaces.
v2: Keep the structs properly aligned (Eric).
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b10c05d4ffaf67786b48b978871e1015b3840653
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Aug 24 23:57:16 2016 +0100
egl/x11: don't crash if dri2_dpy->conn is NULL
The dri3 version of commits 60e9c35b3a0 and 6de9a03bed4.
While using xcb_connect() guarantees that we always get a non NULL
return value, XGetXCBConnection() does/can not.
CC: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f871946594129500a67c05a6d9fe99db54b4bb64
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Aug 24 23:32:27 2016 +0100
egl/dri2: rework dri2_egl_display::extensions storage
Remove the error prone fixed size array.
While we're here also rename to loader_extensions like in the GLX code.
v2: Rebase. Keep image_loader_extension within the wayland_drm
dri2_loader_extensions list.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7b8108289fbef03ec465cf3b418eb65ff18d80d
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 18:47:52 2016 +0100
egl/dri2: remove unused dri2_egl_display::{dri2,swrast}_loader_extension
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e7fcf1b09bfb41a91ba058e987ff7b399296e124
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 18:44:19 2016 +0100
egl/x11: don't populate dri2_dpy->swrast_loader_extension
Analogous to earlier commits.
Note: the actual version of the extension is 1, since it does not
implement .putImage2.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2dbe14af1ea6b9d7af13a3067f52f844c658d412
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 18:39:14 2016 +0100
egl/wayland: don't populate dri2_dpy->swrast_loader_extension
Similar to the dri2 one - the extension stored in struct
dri2_egl_display is unused.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3963a5fc941b00ea8c6491599d4db6bc82c2d647
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 18:29:34 2016 +0100
egl/x11: don't populate dri2_dpy->dri2_loader_extension
Analogous to the earlier android and wayland patches. As we're here we
can drop exposing the old version of the extension.
Any dri loader/driver interface use lower bound checking thus exposing
dri2 loader v3 to a v2 capable driver is perfectly normal.
v2: Preserve compat with dri2_minor < 1. The driver does not know if
there is a protocol to manage getBuffersWithFormat(). It's up-to the
loader to expose the vfunc if there is one. (Kristian)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d2d579da7e1ebd7bc33e7c84921eedc8b8208cda
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 18:21:48 2016 +0100
egl/wayland: don't populate dri2_dpy->dri2_loader_extension
Analogous to the earlier android patch.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=31ef5d4452a208ca13e26f0646f37b25c2a2eb26
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 18:08:13 2016 +0100
egl/surfaceless: trivial coding style fixes
Remove a few gratious blank lines and use the correct level of
indentation.
Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d0155bcbe8eada0386275c382a4b0421dc8418f6
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 17:56:34 2016 +0100
egl/surfaceless: don't check the mask(s) prior to calling dri2_add_config
The latter already does it for us.
As we're here annotate the masks as const and use unsigned for the
index(es).
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ff700f8c22c6c51e7c591c481ef3d91a5c16f340
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 17:33:41 2016 +0100
egl/surfaceless: remove unused dri2_loader_extension implementation
Earlier commit introduced support for image_loader and left the
dri2_loader code dangling/unused. Let's remove it.
Fixes: 63c5d5c6c46 ("Added pbuffer hooks for surfaceless platform")
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6a8fe32430077c44fda8a84c014a986e3fc77204
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 17:23:23 2016 +0100
egl/android: don't populate dri2_dpy->dri2_loader_extension
The extension stored in struct dri2_egl_display isn't used, thus we can
create a static const instance of the extension and point extensions[]
to it.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=675719817e7bf7c5b9da22c02252aca77a41338d
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 13:47:25 2016 +0100
egl/dri2: rework dri2_make_current code flow
Fold duplicate conditional blocks and add a few extra comments ;-)
v2: Bring back the explicit "unbind" logic (Eric), remove NULL derefs.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=07690a289a60f9b12cde59affefeed9e05864dd7
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 13:24:48 2016 +0100
egl/dri2: drop NULL checks prior to dri2_destroy_surface
The function already have the respective check within.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8cf83f9c08a929547062a8ba105a3a75531d72a4
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 18 16:33:39 2016 +0100
egl/dri2: call static functions directly, not via _EGLDriver::API
The indirection is meant to be used by the core EGL implementation in
main. Not in the drivers themselves.
Move the dri2_destroy_surface definition to avoid forward declaration of
the static function.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=532ec2edd878e5691998a1b2132a68a89845b55e
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Fri Jul 15 12:47:37 2016 +0100
egl/dri2: use dri2_egl_display inline wrapper where possible
This way the only places that reference DriverData are the ones that
manipulate it.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6dcf3b4ca7053e9c49780a398c3baabd884ff2c
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Thu Aug 18 16:43:36 2016 +0100
egl/dri2: bail out on NULL dpy in dri2_display_release()
Currently all callers are careful enough not to do that, yet that will
not be the case in the future.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8fb9ea413de31cc6a95ac4c38215b621de728687
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 13:04:37 2016 +0100
egl/dri2: move surface refcounting out of the platform code
All the platforms are duplicating what should be a driver/dri2 thing -
refcounting. Just fold it accordingly.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=02f1158746425617a5e4f5bff4575d7c416d6978
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 11:03:33 2016 +0100
egl/dri2: coding style fix
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a9c92d071d010066349da3a3972313c4d623d18
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 16:33:49 2016 +0100
egl/dri2: non-shared glapi cleanups
For a while now we require shared glapi for EGL, thus we can drop a
few bits from the olden days. Namely - dlopen(NULL...) is not possible,
error out at build stage if so and drop the guard around dlclose().
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b349c11098ed9511510bd2e20e12ab52fe927508
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Aug 16 14:25:19 2016 +0100
egl/dri2: glFlush is not optional, treat it as such
The documentation is clear - one must glFlush the old context on
eglMakeCurrent. Thus keeping it optional is not something we should be
doing. Furthermore if we cannot get the entry point we're likely having
a broken setup/stack.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
More information about the mesa-commit
mailing list