Mesa (master): nvc0/ir: fix comments about instructions info

Samuel Pitoiset hakzsam at kemper.freedesktop.org
Sat Sep 17 15:44:14 UTC 2016


Module: Mesa
Branch: master
Commit: 9b8b69b3c4671b2301f2926f5d310b319a221500
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9b8b69b3c4671b2301f2926f5d310b319a221500

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Sep 13 19:37:24 2016 +0200

nvc0/ir: fix comments about instructions info

The comment for the commutative flags was wrong because OP_MUL is
before OP_MAD. While we are at it add missing opcodes, and fix
the comment about the short forms.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Acked-by: Ilia Mirkin <imirkin at alum.mit.edu>

---

 src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp
index f5981de..f75e395 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp
@@ -156,13 +156,14 @@ void TargetNVC0::initOpInfo()
 
    static const uint32_t commutative[(OP_LAST + 31) / 32] =
    {
-      // ADD, MAD, MUL, AND, OR, XOR, MAX, MIN
+      // ADD, MUL, MAD, FMA, AND, OR, XOR, MAX, MIN, SET_AND, SET_OR, SET_XOR,
+      // SET, SELP, SLCT
       0x0670ca00, 0x0000003f, 0x00000000, 0x00000000
    };
 
    static const uint32_t shortForm[(OP_LAST + 31) / 32] =
    {
-      // ADD, MAD, MUL, AND, OR, XOR, PRESIN, PREEX2, SFN, CVT, PINTERP, MOV
+      // ADD, MUL, MAD, FMA, AND, OR, XOR, MAX, MIN
       0x0670ca00, 0x00000000, 0x00000000, 0x00000000
    };
 




More information about the mesa-commit mailing list