Mesa (master): i965: Remove useless (harmful) assertion

Ben Widawsky bwidawsk at kemper.freedesktop.org
Wed Sep 28 16:43:21 UTC 2016


Module: Mesa
Branch: master
Commit: 29783c0887b3afd345e15e4e6910c04185219812
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=29783c0887b3afd345e15e4e6910c04185219812

Author: Ben Widawsky <ben at bwidawsk.net>
Date:   Tue Sep 27 15:02:12 2016 -0700

i965: Remove useless (harmful) assertion

The code already skips doing the depth stall on gen >= 8, and as we
enable new platforms this assertion will fail needlessly. Instead of
changing the caller, make this simple change.

Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>

---

 src/mesa/drivers/dri/i965/brw_pipe_control.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_pipe_control.c b/src/mesa/drivers/dri/i965/brw_pipe_control.c
index 640bfdc..dd426bf 100644
--- a/src/mesa/drivers/dri/i965/brw_pipe_control.c
+++ b/src/mesa/drivers/dri/i965/brw_pipe_control.c
@@ -234,7 +234,7 @@ brw_emit_pipe_control_write(struct brw_context *brw, uint32_t flags,
 void
 brw_emit_depth_stall_flushes(struct brw_context *brw)
 {
-   assert(brw->gen >= 6 && brw->gen <= 9);
+   assert(brw->gen >= 6);
 
    /* Starting on BDW, these pipe controls are unnecessary.
     *




More information about the mesa-commit mailing list