Mesa (master): intel/vec4: Add some fall through comments

Jason Ekstrand jekstrand at kemper.freedesktop.org
Mon Apr 3 23:58:49 UTC 2017


Module: Mesa
Branch: master
Commit: 405ef7bb335af263266a8bca7acb75614b410b7b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=405ef7bb335af263266a8bca7acb75614b410b7b

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Mon Apr  3 16:24:47 2017 -0700

intel/vec4: Add some fall through comments

Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/intel/compiler/brw_vec4_nir.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/compiler/brw_vec4_nir.cpp
index 2384265399..6dd5789225 100644
--- a/src/intel/compiler/brw_vec4_nir.cpp
+++ b/src/intel/compiler/brw_vec4_nir.cpp
@@ -1310,6 +1310,7 @@ vec4_visitor::nir_emit_alu(nir_alu_instr *instr)
 
    case nir_op_iadd:
       assert(nir_dest_bit_size(instr->dest.dest) < 64);
+      /* fall through */
    case nir_op_fadd:
       inst = emit(ADD(dst, op[0], op[1]));
       inst->saturate = instr->dest.saturate;
@@ -1540,6 +1541,7 @@ vec4_visitor::nir_emit_alu(nir_alu_instr *instr)
    case nir_op_imin:
    case nir_op_umin:
       assert(nir_dest_bit_size(instr->dest.dest) < 64);
+      /* fall through */
    case nir_op_fmin:
       inst = emit_minmax(BRW_CONDITIONAL_L, dst, op[0], op[1]);
       inst->saturate = instr->dest.saturate;
@@ -1548,6 +1550,7 @@ vec4_visitor::nir_emit_alu(nir_alu_instr *instr)
    case nir_op_imax:
    case nir_op_umax:
       assert(nir_dest_bit_size(instr->dest.dest) < 64);
+      /* fall through */
    case nir_op_fmax:
       inst = emit_minmax(BRW_CONDITIONAL_GE, dst, op[0], op[1]);
       inst->saturate = instr->dest.saturate;
@@ -2054,6 +2057,7 @@ vec4_visitor::nir_emit_alu(nir_alu_instr *instr)
    case nir_op_iabs:
    case nir_op_ineg:
       assert(nir_dest_bit_size(instr->dest.dest) < 64);
+      /* fall through */
    case nir_op_fabs:
    case nir_op_fneg:
    case nir_op_fsat:




More information about the mesa-commit mailing list